[
https://issues.apache.org/jira/browse/YARN-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373450#comment-16373450
]
Eric Yang commented on YARN-7836:
---------------------------------
+1 the patch works as advertised.
> YARN Service component update PUT API should not use component name from JSON
> body
> ----------------------------------------------------------------------------------
>
> Key: YARN-7836
> URL: https://issues.apache.org/jira/browse/YARN-7836
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, yarn-native-services
> Reporter: Gour Saha
> Assignee: Gour Saha
> Priority: Major
> Attachments: YARN-7836.001.patch, YARN-7836.002.patch,
> YARN-7836.003.patch
>
>
> The YARN Service PUT API for component update should not use component name
> from the JSON body. The component update PUT URI is as follows -
> [http://localhost:9191/app/v1/services/]<service_name>/components/<comp_name>
> e.g. [http://localhost:9191/app/v1/services/hello-world/components/hello]
> The component name is already in the URI, hence the JSON body expected should
> be only -
> {noformat}
> {
> "number_of_containers": 3
> }
> {noformat}
> It should not expect the name attribute in the JSON body. In fact, if the
> JSON body contains a name attribute with value anything other than the
> <comp_name> in the path param, we should send a 400 bad request saying they
> do not match. If they are the same, it should be okay and we can process the
> request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
