Konstantinos Karanasos commented on YARN-7953:

Thanks for working on this and for splitting the patches, [~curino].

The data structures make sense. Some comments below:

In {{FedQueue}}:
 * Should idealalloc be part of the FedQueue? Maybe targetAlloc? But still not 
sure if it should be part of this class.
 * Should we abstract out the creation of the JAXB context, the toString, and 
the reading from JSON in a Util class, given we are using it in various 
classes? JAXB context and toString are currently in FedQueue and 
FederationGlobalView, the reading is in the test classes. The loadFile method 
from the test classes can be put in there too.
 * Split the propagate to two methods, one for the top-down traversal and one 
for the bottom-up.
 * Not clear what mergeQueues does. Does it take multiple subcluster queues and 
combines them in a global queue?
 * Is recursiveSetOfTotCap used? I guess it could also be used in the propagate 
(especially after we break it)?

In {{FederationGlobalView}}:
 * Does this class need a resource calculator?
 * Shouldn't we have a method that builds the global view inside this class?

Nits (all but the first are in FedQueue):
 * Is the org.ojalgo dependency needed in the pom?
 * Better javadoc for class (explain GPG and global policies a bit)
 * FedQueue -> FederatedQueue or FederationQueue
 * scope -> subcluster?
 * getChildrenByName -> getChildByName


> [GQ] Data structures for federation global queues calculations
> --------------------------------------------------------------
>                 Key: YARN-7953
>                 URL: https://issues.apache.org/jira/browse/YARN-7953
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>            Priority: Major
>         Attachments: YARN-7953.v1.patch
> This Jira tracks data structures and helper classes used by the core 
> algorithms of YARN-7402 umbrella Jira (currently YARN-7403, and YARN-7834).

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to