[ https://issues.apache.org/jira/browse/YARN-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374508#comment-16374508 ]
Rohith Sharma K S edited comment on YARN-7346 at 2/23/18 3:40 PM: ------------------------------------------------------------------ bq. Even if this module for HBase 2.0.0 support isn't the default used in trunk, shouldn't we still be testing changes to the module? This is the basic conditional compilation modules gap. For this, in last ATSv2 community call decided to use YARN-7055 branch as HBase-2.0 default module. And all the patch going into trunk should also be verified for the branch YARN-7055 as well that confirms that nothing break for HBase-2 module. Otherwise we can't proceed ahead with any decisions ending with this Jenkins issue. There are many other issue to be addressed for stability. Umbrella YARN-7213 tracks it for HBase-2.0 which need to be addressed. This is the first patch with conditional compilation modules to be committed. We ensures that default compilation, packaging, findbug, checkstyle and others doesn't break anything from previous ones. was (Author: rohithsharma): bq. Even if this module for HBase 2.0.0 support isn't the default used in trunk, shouldn't we still be testing changes to the module? This is the basic conditional compilation modules gap. For this, in last ATSv2 community call decided to use YARN-7055 branch as HBase-2.0 default module. And all the patch going into trunk should also be verified for the branch YARN-7055 as well that confirms that nothing break for HBase-2 module. Otherwise we can't proceed ahead with any decisions ending with this Jenkins issue. There are many other issue to be addressed for stability. Umbrella YARN-7213 tracks it for HBase-2.0 which need to be addressed. This is the fist patch with conditional compilation modules to be committed. We ensures that default compilation, packaging, findbug, checkstyle and others doesn't break anything from previous ones. > Fix compilation errors against hbase2 beta release > -------------------------------------------------- > > Key: YARN-7346 > URL: https://issues.apache.org/jira/browse/YARN-7346 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Ted Yu > Assignee: Haibo Chen > Priority: Major > Attachments: YARN-7346.00.patch, YARN-7346.01.patch, > YARN-7346.02.patch, YARN-7346.03-incremental.patch, YARN-7346.03.patch, > YARN-7346.04-incremental.patch, YARN-7346.04.patch, YARN-7346.05.patch, > YARN-7346.06.patch, YARN-7346.prelim1.patch, YARN-7346.prelim2.patch, > YARN-7581.prelim.patch > > > When compiling hadoop-yarn-server-timelineservice-hbase against 2.0.0-alpha3, > I got the following errors: > https://pastebin.com/Ms4jYEVB > This issue is to fix the compilation errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org