[
https://issues.apache.org/jira/browse/YARN-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755055#comment-13755055
]
Hadoop QA commented on YARN-1120:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600495/YARN-1120.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1808//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1808//console
This message is automatically generated.
> Make ApplicationConstants.Environment.USER definition OS neutral
> ----------------------------------------------------------------
>
> Key: YARN-1120
> URL: https://issues.apache.org/jira/browse/YARN-1120
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Priority: Minor
> Attachments: YARN-1120.patch
>
>
> In YARN-557, we added some code to make {{
> ApplicationConstants.Environment.USER}} has OS-specific definition in order
> to fix the unit test TestUnmanagedAMLauncher. In YARN-571, the relevant test
> code was corrected. In YARN-602, we actually will explicitly set the
> environment variables for the child containers. With these changes, I think
> we can revert the YARN-557 change to make {{
> ApplicationConstants.Environment.USER}} OS neutral. The main benefit is that
> we can use the same method over the Enum constants. This should also fix the
> TestContainerLaunch#testContainerEnvVariables failure on Windows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
