[ 
https://issues.apache.org/jira/browse/YARN-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yufei Gu updated YARN-7968:
---------------------------
    Description: 
After YARN-7139, the new application can get correct queue name in its 
submission context. We need to do the same thing for application recovering. 
{code}
      if (isAppRecovering) {
        if (LOG.isDebugEnabled()) {
          LOG.debug(applicationId
              + " is recovering. Skip notifying APP_ACCEPTED");
        }
      } else {
        // During tests we do not always have an application object, handle
        // it here but we probably should fix the tests
        if (rmApp != null && rmApp.getApplicationSubmissionContext() != null) {
          // Before we send out the event that the app is accepted is
          // to set the queue in the submissionContext (needed on restore etc)
          rmApp.getApplicationSubmissionContext().setQueue(queue.getName());
        }
        rmContext.getDispatcher().getEventHandler().handle(
            new RMAppEvent(applicationId, RMAppEventType.APP_ACCEPTED));
      }
{code}
We can do it by moving the {{rmApp.getApplicationSubmissionContext().setQueue}} 
block out of the if-else block. cc [~wilfreds].

  was:
After YARN-7139, the new application can get correct queue name in its 
submission context. We need to do the same thing for application recovering. 
{code}
      if (isAppRecovering) {
        if (LOG.isDebugEnabled()) {
          LOG.debug(applicationId
              + " is recovering. Skip notifying APP_ACCEPTED");
        }
      } else {
        // During tests we do not always have an application object, handle
        // it here but we probably should fix the tests
        if (rmApp != null && rmApp.getApplicationSubmissionContext() != null) {
          // Before we send out the event that the app is accepted is
          // to set the queue in the submissionContext (needed on restore etc)
          rmApp.getApplicationSubmissionContext().setQueue(queue.getName());
        }
        rmContext.getDispatcher().getEventHandler().handle(
            new RMAppEvent(applicationId, RMAppEventType.APP_ACCEPTED));
      }
{code}
We can do it by move the {{rmApp.getApplicationSubmissionContext().setQueue}} 
block out of the if-else block. cc [~wilfreds].


> Reset the queue name in submission context while recovering an application
> --------------------------------------------------------------------------
>
>                 Key: YARN-7968
>                 URL: https://issues.apache.org/jira/browse/YARN-7968
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>    Affects Versions: 3.1.0
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>            Priority: Major
>
> After YARN-7139, the new application can get correct queue name in its 
> submission context. We need to do the same thing for application recovering. 
> {code}
>       if (isAppRecovering) {
>         if (LOG.isDebugEnabled()) {
>           LOG.debug(applicationId
>               + " is recovering. Skip notifying APP_ACCEPTED");
>         }
>       } else {
>         // During tests we do not always have an application object, handle
>         // it here but we probably should fix the tests
>         if (rmApp != null && rmApp.getApplicationSubmissionContext() != null) 
> {
>           // Before we send out the event that the app is accepted is
>           // to set the queue in the submissionContext (needed on restore etc)
>           rmApp.getApplicationSubmissionContext().setQueue(queue.getName());
>         }
>         rmContext.getDispatcher().getEventHandler().handle(
>             new RMAppEvent(applicationId, RMAppEventType.APP_ACCEPTED));
>       }
> {code}
> We can do it by moving the 
> {{rmApp.getApplicationSubmissionContext().setQueue}} block out of the if-else 
> block. cc [~wilfreds].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to