[
https://issues.apache.org/jira/browse/YARN-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375491#comment-16375491
]
Weiwei Yang commented on YARN-7929:
-----------------------------------
Hi [~yangjiandan]
Thanks for working on this, this is very helpful to eval scheduler performance
when have opportunistic containers enabled. Some comments regarding to your
patch
*ContainerSimulator*
# line 53: Can we leave the old constructor along and create a new one with
additional argument ExcutionType? This can help to minimize the changes
*NMSimulator*
# line 76: can we replace {{waterLevel}} to something like
{{resourceUtilizationRatio}} ?
# line 139: instead of having a check here, we should place a check earlier
during init, if configuration is not valid, fail directly. Maybe move to
SLSRunner#init
# line 140: please use safe cast from float to int
*SynthJob*
# Similar to the first comment, can we add a new constructor instead of
modifying the old one?
*Misc*
# It looks like you have modified syn.json, syn_generic.json and
syn_stream.json to all use opportunistic execution type, will this affect
existing UT coverage on guaranteed containers? If so, I suggest to add new test
case for this.
# Please fix checkstyle issues, there are a lot of lines exceed 80 length
Thanks
> SLS supports setting container execution
> ----------------------------------------
>
> Key: YARN-7929
> URL: https://issues.apache.org/jira/browse/YARN-7929
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler-load-simulator
> Reporter: Jiandan Yang
> Assignee: Jiandan Yang
> Priority: Major
> Attachments: YARN-7929.001.patch, YARN-7929.002.patch
>
>
> SLS currently support three tracetype, SYNTH, SLS and RUMEN, but trace file
> can not set execution type of container.
> This jira will introduce execution type in SLS to help better simulation.
> This will help the perf testing with regarding to the Opportunistic
> Containers.
> RUMEN has default execution type GUARANTEED
> SYNTH set execution type by field map_execution_type and
> reduce_execution_type
> SLS set execution type by field container.execution_type
> For compatibility set GUARANTEED as default value when not setting above
> fields in trace file
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
