Arun Suresh commented on YARN-7972:

[~cheersyang], went thru the latest patch.

Am not sure I fully understand the need for the {{Evaluable}} interface. If you 
are introducing it, then we must ensure evaluate is always required to be 
called. We should not have if-thens like:
80          if (namespace.isIntraApp()) {
81            // self
82            // need to eval the namespace to set proper scope
83            if (currentAppId != null) {
84              namespace.evaluate(ImmutableSet.of(currentAppId));
85            }
86            return namespace;
87          } else if (namespace.isSingleInterApp()) {
88            // app-id
89            // no eval needed
90            return namespace;

Currently, I see that only SELF namespace use the evaluate method, and it takes 
a singleton set as argument - if my understanding is currect, I assume later 
when we have NOT_SELF and multiple app scopes, then the size of set would be 
all other apps and each specific app respectively. right ? Wouldnt creating 
that set at parse time be very in-efficient ?

> Support inter-app placement constraints for allocation tags by application ID
> -----------------------------------------------------------------------------
>                 Key: YARN-7972
>                 URL: https://issues.apache.org/jira/browse/YARN-7972
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7972.001.patch, YARN-7972.002.patch, 
> YARN-7972.003.patch, YARN-7972.004.patch, YARN-7972.005.patch, 
> YARN-7972.006.patch
> Per discussion in [this 
> comment|https://issues.apache.org/jira/browse/YARN-6599focusedCommentId=16319662&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16319662]
>  in  YARN-6599, we need to support inter-app PC for allocation tags.
> This will help to do better placement when dealing with potential competing 
> resource applications, e.g don't place two tensorflow workers from two 
> different applications on one same node.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to