Gour Saha commented on YARN-7523:

[~csingh], thank you for the patch. It looks good.

Few comments -
1. In Service.java, add the builder methods for version and description, just 
like all others. Like for the one below for name -
  public Service name(String name) {
    this.name = name;
    return this;
2. In YARN-Services-Examples.md, add the description attribute in the POST 
request example for hbase-app-1

3. In ApiServer.java, method createService, can you modify the diagnostics 
message a little bit to explicitly use the "version" keyword. This is to avoid 
confusion that the service name is this whole string 
“<service_name>:<version>”. So modify it to something like this -
        serviceStatus.setDiagnostics("Service " + service.getName() + “ version 
" +
            service.getVersion() + " saved.");
4. Can you add an additional test in TestServiceApiUtil.java method 
testResourceValidation which simulates ERROR_APPLICATION_VERSION_INVALID?

> Introduce description and version field in Service record
> ---------------------------------------------------------
>                 Key: YARN-7523
>                 URL: https://issues.apache.org/jira/browse/YARN-7523
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gour Saha
>            Assignee: Chandni Singh
>            Priority: Major
>             Fix For: yarn-native-services
>         Attachments: YARN-7523.001.patch
> YARN-7512 would need version field in Service record. It would be good to 
> introduce a description field also to allow service owners to capture some 
> details which can be used to display in Service catalog as well.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to