[
https://issues.apache.org/jira/browse/YARN-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384284#comment-16384284
]
Gour Saha commented on YARN-7523:
---------------------------------
[~csingh], thank you for the patch. It looks good.
Few comments -
1. In Service.java, add the builder methods for version and description, just
like all others. Like for the one below for name -
{code:java}
public Service name(String name) {
this.name = name;
return this;
}
{code}
2. In YARN-Services-Examples.md, add the description attribute in the POST
request example for hbase-app-1
3. In ApiServer.java, method createService, can you modify the diagnostics
message a little bit to explicitly use the "version" keyword. This is to avoid
confusion that the service name is this whole string
“<service_name>:<version>”. So modify it to something like this -
{code:java}
serviceStatus.setDiagnostics("Service " + service.getName() + “ version
" +
service.getVersion() + " saved.");
{code}
4. Can you add an additional test in TestServiceApiUtil.java method
testResourceValidation which simulates ERROR_APPLICATION_VERSION_INVALID?
> Introduce description and version field in Service record
> ---------------------------------------------------------
>
> Key: YARN-7523
> URL: https://issues.apache.org/jira/browse/YARN-7523
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gour Saha
> Assignee: Chandni Singh
> Priority: Major
> Fix For: yarn-native-services
>
> Attachments: YARN-7523.001.patch
>
>
> YARN-7512 would need version field in Service record. It would be good to
> introduce a description field also to allow service owners to capture some
> details which can be used to display in Service catalog as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
