[
https://issues.apache.org/jira/browse/YARN-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386633#comment-16386633
]
Wangda Tan commented on YARN-7891:
----------------------------------
[~xgong],
Thanks for explanation, so IIUC, logic of the method {{getAllNodeFiles}} is:
1) If not HAR file present, returns all {{nodeFiles}}
2) If any HAR file present, only return all files under the existed HAR file.
If HAR file is treated as final log aggregation result, this logic should be
correct to me. (From the MAPREDUCE-6415, it looks final):
{code} .
235 @VisibleForTesting
236 void findAggregatedApps() throws IOException, YarnException {
237 YarnClient client = YarnClient.createYarnClient();
238 try {
239 client.init(getConf());
240 client.start();
241 List<ApplicationReport> reports = client.getApplications();
242 for (ApplicationReport report : reports) {
243 LogAggregationStatus aggStatus =
report.getLogAggregationStatus();
244 if (aggStatus.equals(LogAggregationStatus.SUCCEEDED) ||
245 aggStatus.equals(LogAggregationStatus.FAILED)) {
246 eligibleApplications.add(report);
247 }
248 }
249 } finally {
250 if (client != null) {
251 client.stop();
252 }
253 }
254 }
{code}
If you can confirm my understanding this correct, the patch looks good to me.
> LogAggregationIndexedFileController should support HAR file
> -----------------------------------------------------------
>
> Key: YARN-7891
> URL: https://issues.apache.org/jira/browse/YARN-7891
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Priority: Major
> Attachments: YARN-7891.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
