Weiwei Yang commented on YARN-8007:

Hi [~yangjiandan]

Thanks for initiating this, it makes a lot of sense to help test scheduler perf 
with placement constraints,

There are a few general comments to your patch
 # Instead of using {{SourceTags}} abstraction, lets follow the public API in 
scheduling request, which is to provide a Set<String> of source tags and a 
PlacementConstraint. I think you will need 2 configs,
 allocation_tags: foo,bar
 placement_constraint: notin,node,foo
 this way we can honor number of tasks in the config.
 # I don't think we need to add placement constraint field in 
ContainerSimulator, a placement constraint is request level, not container 
 # Have you tried to run this and how this works out?


> Support specifying placement constraint for task containers in SLS
> ------------------------------------------------------------------
>                 Key: YARN-8007
>                 URL: https://issues.apache.org/jira/browse/YARN-8007
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler-load-simulator
>            Reporter: Jiandan Yang 
>            Assignee: Jiandan Yang 
>            Priority: Major
>         Attachments: YARN-8007.001.patch
> YARN-6592 introduces placement constraint. Currently SLS does not support 
> specify placement constraint. 
> In order to help better perf test, we should be able to support specify 
> placement for containers in sls configuration.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to