[
https://issues.apache.org/jira/browse/YARN-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392283#comment-16392283
]
Giovanni Matteo Fumarola commented on YARN-7707:
------------------------------------------------
Thanks [~youchen] for the patch, few comments:
*{{DefaultGlobalPolicy}}*
* It should be called {{NoOpGlobalPolicy}} or something similar.
*PolicyGenerator*
* {{invokeRMWebService}} can return null. Please add NullPointer checks in
{{getSchedulerInfo}} and {{getInfos.}}
* Line 193. Change the conf.get into
{code:java}
conf.get(YarnConfiguration.GPG_POLICY_GENERATOR_BLACKLIST);
{code}
and add a NullPointer check after. It makes cleaner.
*TestGPGPolicyFacade*
* Add javadoc for the tests.
In general keep the word {{SubCluster}} in this way around the patch.
> [GPG] Policy generator framework
> --------------------------------
>
> Key: YARN-7707
> URL: https://issues.apache.org/jira/browse/YARN-7707
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Carlo Curino
> Assignee: Young Chen
> Priority: Major
> Labels: federation, gpg
> Attachments: YARN-7707-YARN-7402.01.patch,
> YARN-7707-YARN-7402.02.patch, YARN-7707-YARN-7402.03.patch,
> YARN-7707-YARN-7402.04.patch, YARN-7707-YARN-7402.05.patch,
> YARN-7707-YARN-7402.06.patch, YARN-7707-YARN-7402.07.patch,
> YARN-7707-YARN-7402.08.patch, YARN-7707-YARN-7402.09.patch
>
>
> This JIRA tracks the development of a generic framework for querying
> sub-clusters for metrics, running policies, and updating them in the
> FederationStateStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
