[
https://issues.apache.org/jira/browse/YARN-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399907#comment-16399907
]
Wangda Tan commented on YARN-7461:
----------------------------------
Thanks [~Tao Yang], [~cheersyang], [~templedf].
I'm not sure if this is correct, IMHO, for ratio(a,b), we should get a >1
result (when a > b) and <1 (when a < b) under the context of DRF. Otherwise it
will be inconsistent to me. We recently saw some issues in CapacityScheduler
preemption which is caused by similar issues. Please see YARN-8020/YARN-6538
for more details.
Since this calculator exists in common package, in order to run RM unit tests,
you may need to change some random things in resourcemanager.
> DominantResourceCalculator#ratio calculation problem when right resource
> contains zero value
> --------------------------------------------------------------------------------------------
>
> Key: YARN-7461
> URL: https://issues.apache.org/jira/browse/YARN-7461
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha4
> Reporter: Tao Yang
> Assignee: Tao Yang
> Priority: Minor
> Attachments: YARN-7461.001.patch, YARN-7461.002.patch,
> YARN-7461.003.patch
>
>
> Currently DominantResourceCalculator#ratio may return wrong result when right
> resource contains zero value. For example, there are three resource types
> such as <memory-mb, vcores, vssd>, leftResource=<5, 5, 0> and
> rightResource=<10, 10, 0>, we expect the result of
> DominantResourceCalculator#ratio(leftResource, rightResource) is 0.5 but
> currently is NaN.
> There should be a verification before divide calculation to ensure that
> dividend is not zero.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
