[ 
https://issues.apache.org/jira/browse/YARN-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403157#comment-16403157
 ] 

Wangda Tan commented on YARN-8028:
----------------------------------

[~sunilg], 
Thanks for review. 

1/2: updated. 
3: The queueACLsManager.checkAccess() contains RMApp which is not desired. This 
check happens before application created. I'm not sure why we added a check 
queue access API with RMApp/application field. Maybe just because developer 
wants to reuse the same method. Personally I would prefer a more clear API. So 
I use checkAccess API. If you look at implementation of LeafQueue#checkAccess, 
it uses the authorizer. To me I think we should fix this code issue in a 
separate JIRA and keep this change minimum.

> Support authorizeUserAccessToQueue in RMWebServices
> ---------------------------------------------------
>
>                 Key: YARN-8028
>                 URL: https://issues.apache.org/jira/browse/YARN-8028
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Major
>         Attachments: YARN-8028.001.patch, YARN-8028.002.patch
>
>
> Currently we have {{QueueUserACLInfo}} in ApplicationClient, we should 
> support similar API in REST API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to