[
https://issues.apache.org/jira/browse/YARN-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757484#comment-13757484
]
Zhijie Shen commented on YARN-696:
----------------------------------
Hi Trevor, the patch is almost good except:
1.
{code}
+ if (checkAppStates) {
+ boolean match = false;
+ for (String appState : appStates) {
+ if (appState.equals(rmapp.getState().toString().toLowerCase())) {
+ match = true;
+ }
+ }
+ if (!match) {
+ continue;
+ }
+ }
{code}
Is it more concise to change to:
{code}
+ if (checkAppStates
+ && !appStates.contains(rmapp.getState().toString().toLowerCase())) {
+ continue;
+ }
{code}
2. Some lines have more than 80 chars. Would you please break them?
Sorry for being so harsh, but I think these will make the patch perfect. Thanks!
> Enable multiple states to to be specified in Resource Manager apps REST call
> ----------------------------------------------------------------------------
>
> Key: YARN-696
> URL: https://issues.apache.org/jira/browse/YARN-696
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.0.4-alpha
> Reporter: Trevor Lorimer
> Assignee: Trevor Lorimer
> Attachments: YARN-696.diff, YARN-696.diff, YARN-696.diff,
> YARN-696.diff
>
>
> Within the YARN Resource Manager REST API the GET call which returns all
> Applications can be filtered by a single State query parameter (http://<rm
> http address:port>/ws/v1/cluster/apps).
> There are 8 possible states (New, Submitted, Accepted, Running, Finishing,
> Finished, Failed, Killed), if no state parameter is specified all states are
> returned, however if a sub-set of states is required then multiple REST calls
> are required (max. of 7).
> The proposal is to be able to specify multiple states in a single REST call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
