Zhenhao Li created YARN-8057:
--------------------------------

             Summary: Inadequate information for handling catch clauses
                 Key: YARN-8057
                 URL: https://issues.apache.org/jira/browse/YARN-8057
             Project: Hadoop YARN
          Issue Type: Improvement
          Components: api, yarn
    Affects Versions: 3.0.0
            Reporter: Zhenhao Li


Their are some situations that different exception types are caught, but the 
handling of those exceptions can not show the differences of those types. Here 
are the code snippet we found which have this problem:

*org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*

[https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]

At Line *125* and Line *129.* We can see that two exception types are caught, 
but the logging statements here can not show the exception type at all. It may 
cause confusions to the person who are reading the log, the person can not know 
what exception happened here.

 

Maybe adding stack trace information to these two logging statements is a 
simple way to improve it.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to