[
https://issues.apache.org/jira/browse/YARN-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410533#comment-16410533
]
Wangda Tan commented on YARN-7574:
----------------------------------
Thanks [~suma.shivaprasad], in general patch looks good. Just a few minor
comments:
1) getAvailableCapacity: can be expanded for better readability.
2) This else may not be necessary:
{code}
else{
throw new SchedulerDynamicEditException("Child queue absolute capacity "
+ "is initialized to 0. Check parent queue's " + managedParentQueue
.getQueueName() + " leaf queue template configuration");
}
{code}
We should check childQueueAbsoluteCapacity > 0 prior to this correct?
> Add support for Node Labels on Auto Created Leaf Queue Template
> ---------------------------------------------------------------
>
> Key: YARN-7574
> URL: https://issues.apache.org/jira/browse/YARN-7574
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Suma Shivaprasad
> Assignee: Suma Shivaprasad
> Priority: Major
> Attachments: YARN-7574.1.patch, YARN-7574.2.patch, YARN-7574.3.patch,
> YARN-7574.4.patch, YARN-7574.5.patch
>
>
> YARN-7473 adds support for auto created leaf queues to inherit node labels
> capacities from parent queues. Howebver there is no support for leaf queue
> template to allow different configured capacities for different node labels.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
