[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413536#comment-16413536
]
Sunil G commented on YARN-7988:
-------------------------------
Thanks [~bibinchundatt]
Few comments
# *public abstract class AbstractFSNodeStore<M>* . Please update what is this
M? more cleaner declaration will be helpful if we mention the type clear.
# Missing javadoc. *public boolean isCentralizedConfiguration*
# Why StoreSchema need to be static?
# In {{editLogOp}} and {{mirrorOp}} , do we need to have the value as *Class<?
extends FSNodeStoreLogOp>* ? Why cant we store a singleton object or something
like a simpler obj instance instead of static class.
Also cud u pls do a test to ensure that we dont break compatibility. LIke
loading 2.8/2.7 mirror file and recover label as per today schema.
> Refactor FSNodeLabelStore code for attributes store support
> -----------------------------------------------------------
>
> Key: YARN-7988
> URL: https://issues.apache.org/jira/browse/YARN-7988
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-7988-YARN-3409.002.patch,
> YARN-7988-YARN-3409.003.patch, YARN-7988-YARN-3409.004.patch,
> YARN-7988-YARN-3409.005.patch, YARN-7988.001.patch
>
>
> # Abstract out file FileSystemStore operation
> # Define EditLog Operartions and Mirror operation
> # Support compatibility with old nodelabel store
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
