[ https://issues.apache.org/jira/browse/YARN-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758047#comment-13758047 ]
Jason Lowe commented on YARN-1145: ---------------------------------- I think the logic behind calling close on the TFile.Reader is consistency -- if an object has a close() method, probably prudent to call as it may not always do nothing in the future. The real fix with this patch is in AggregatedLogsBlock which will call close() on the LogReader which will in turn close the data stream and release the associated socket. > Potential file handle leak in aggregated logs web ui > ---------------------------------------------------- > > Key: YARN-1145 > URL: https://issues.apache.org/jira/browse/YARN-1145 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.0.5-alpha, 0.23.9, 2.1.1-beta > Reporter: Rohith Sharma K S > Assignee: Rohith Sharma K S > Attachments: MAPREDUCE-5486.patch > > > Any problem in getting aggregated logs for rendering on web ui, then > LogReader is not closed. > Now, it reader is not closed which causing many connections in close_wait > state. > hadoopuser@hadoopuser:> jps > *27909* JobHistoryServer > DataNode port is 50010. When greped with DataNode port, many connections are > in CLOSE_WAIT from JHS. > hadoopuser@hadoopuser:> netstat -tanlp |grep 50010 > tcp 0 0 10.18.40.48:50010 0.0.0.0:* LISTEN > 21453/java > tcp 1 0 10.18.40.48:20596 10.18.40.48:50010 > CLOSE_WAIT *27909*/java > tcp 1 0 10.18.40.48:19667 10.18.40.152:50010 > CLOSE_WAIT *27909*/java > tcp 1 0 10.18.40.48:20593 10.18.40.48:50010 > CLOSE_WAIT *27909*/java > tcp 1 0 10.18.40.48:12290 10.18.40.48:50010 > CLOSE_WAIT *27909*/java > tcp 1 0 10.18.40.48:19662 10.18.40.152:50010 > CLOSE_WAIT *27909*/java -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira