[ 
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414910#comment-16414910
 ] 

Rohith Sharma K S commented on YARN-8048:
-----------------------------------------

Thanks [~leftnoteasy] for review.. 

bq. Why ServiceManager is being initialized in RM and SystemServiceManager is 
being initialized in ApiServerWebApp? I guess adding to ApiServerWebApp is for 
non-RM deployment of API server, correct? I think we don't have to do this in 
the first phase.
Right, for non RM deployment scenarios to handle I added this. Though non RM 
deployment not used, I think its better to keep it. 

bq. And both of them are not added to CompositeService so stopService won't be 
invoked during daemon shutdown. And is it enough to handle RM HA?
SystemServiceManager extends AbstractService. So it should be called. Here is 
the log message from RM which I added
{noformat}
2018-03-26 13:30:55,815 INFO 
org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: Transitioning to 
standby state
2018-03-26 13:30:55,816 INFO 
org.apache.hadoop.yarn.service.client.SystemServiceManager: Stopping 
org.apache.hadoop.yarn.service.client.SystemServiceManager
2018-03-26 13:30:55,818 WARN 
org.apache.hadoop.yarn.server.resourcemanager.amlauncher.ApplicationMasterLauncher:
 
org.apache.hadoop.yarn.server.resourcemanager.amlauncher.ApplicationMasterLauncher$LauncherThread
 interrupted. Returning.
2018-03-26 13:30:55,819 INFO org.apache.hadoop.ipc.Server: Stopping server on 
25001
{noformat}

bq. Why add a ServiceWebClient? Is it sufficient to use ServiceClient? 
I took approach to go ahead with web service model rather than admin client 
model because I wasn't sure how does ApiAdminClient behaves in secured 
environment. ApiAdminClient does some local fs operations to read services 
which is not required for us. And also ApiAdminClient doesn't have direct API 
to launch services given Service in parameter. This API we need to introduce 
it. I will check the feasibility and let me update the patch based on this.

> Support auto-spawning of admin configured services during bootstrap of 
> rm/apiserver
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-8048
>                 URL: https://issues.apache.org/jira/browse/YARN-8048
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Major
>         Attachments: YARN-8048.001.patch, YARN-8048.002.patch
>
>
> Goal is to support auto-spawning of admin configured services during 
> bootstrap of resourcemanager/apiserver. 
> *Requirement:* Some of the  services might required to be consumed by yarn 
> itself ex: Hbase for atsv2. Instead of depending on user installed HBase or 
> sometimes user may not required to install HBase at all, in such conditions 
> running HBase app on YARN will help for ATSv2.
> Before YARN cluster is started, admin configure these services spec and place 
> it in common location in HDFS. At the time of RM/apiServer bootstrap, these 
> services will be submitted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to