[ 
https://issues.apache.org/jira/browse/YARN-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758892#comment-13758892
 ] 

Alejandro Abdelnur commented on YARN-1098:
------------------------------------------

ResourceManager: the ActiveServices should be instantiated on service start, 
this would take care of creating a whole new set of services on every start 
solving the restart issue you reported.
ResourceManager.ActiveServices: webApp instance var seems not to be 
instantiated anywhere.
ResourceManager.ActiveServices: is there any reason why the instantiation of 
components in the serviceInit() is delegate to the ResourceManager instead 
being brought into the ActiveServices class?
ResourceManager.ActiveServices: wouldn't make the code in the RM simpler if the 
ActiveServices class is  an outer class? 
ResourceManager: the setRMStateStore() method takes 3 params RMContext, 
Dispatcher and RMStateStore. The last 2 are part of the context already, 
wouldn't make sense to just pass the context?

                
> Separate out RM services into "Always On" and "Active"
> ------------------------------------------------------
>
>                 Key: YARN-1098
>                 URL: https://issues.apache.org/jira/browse/YARN-1098
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>              Labels: ha
>         Attachments: yarn-1098-1.patch, yarn-1098-2.patch, 
> yarn-1098-approach.patch, yarn-1098-approach.patch
>
>
> From discussion on YARN-1027, it makes sense to separate out services that 
> are stateful and stateless. The stateless services can  run perennially 
> irrespective of whether the RM is in Active/Standby state, while the stateful 
> services need to  be started on transitionToActive() and completely shutdown 
> on transitionToStandby().
> The external-facing stateless services should respond to the client/AM/NM 
> requests depending on whether the RM is Active/Standby.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to