[
https://issues.apache.org/jira/browse/YARN-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421589#comment-16421589
]
Sunil G commented on YARN-7875:
-------------------------------
Thanks [~bibinchundatt]. Few more minor nits.
# I think javadoc is missing in NodeAttributeStore for apis like *init* /
*recover*
# {{enum StoreType}} has new entry named {{NODE_LABEL_ATTRIBUTE}} . This seems
not correct. Its rather could be a simple NODE_ATTRIBUTE
# In {{getDefaultFSNodeAttributeRootDir}}, we use different patch for
nodelabel and nodeattribute. Could u pls confirm that we are logging this name
of dir in INFO log in *initStore*
# In below code, i think there is a chance of failure when custom class is
configured by admin and if its not valid.
{code:java}
133 this.store = ReflectionUtils.newInstance(
134 conf.getClass(YarnConfiguration.FS_NODE_ATTRIBUTE_STORE_IMPL_CLASS,
135 FileSystemNodeAttributeStore.class, NodeAttributeStore.class),
136 conf);{code}
> AttributeStore for store and recover attributes
> -----------------------------------------------
>
> Key: YARN-7875
> URL: https://issues.apache.org/jira/browse/YARN-7875
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-7875-WIP.patch, YARN-7875-YARN-3409.001.patch,
> YARN-7875-YARN-3409.002.patch, YARN-7875-YARN-3409.003.patch,
> YARN-7875-YARN-3409.004.patch
>
>
> Similar to NodeLabelStore need to support NodeAttributeStore for persisting
> attributes mapping to Nodes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
