[ 
https://issues.apache.org/jira/browse/YARN-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421690#comment-16421690
 ] 

Naganarasimha G R edited comment on YARN-8100 at 4/1/18 3:41 PM:
-----------------------------------------------------------------

Thanks for the patch & raising the issue for discussion [~bibinchundatt].

IMHO, i would suggest to have it as host name itself, it will be uniform 
everywhere both while setting and fetching attributes. I was initially thinking 
of having an overloaded method for scheduler perse but later changed my mind 
and thinking of having some helpers inside scheduler to fetch the attributes 
from the manager based on NodeId which internally can call manager's api 
passing the hostname. 

As well in the current code we are only storing the Node's Hostname in the 
Manager and hence it would not be ideal to return NodeId with port always as 
*"0"*.


was (Author: naganarasimha):
Thanks for the patch & raising the issue for discussion [~bibinchundatt].

IMHO, i would suggest to have it as host name itself, it will be uniform 
everywhere both while setting and fetching attributes. I was initially thinking 
of having an overloaded method for scheduler perse but later changed my mind 
and thinking of having some helpers inside scheduler to fetch the attributes 
from the manager based on NodeId which internally can call manager's api 
passing the hostname. 

> Support API interface for node attribute query
> ----------------------------------------------
>
>                 Key: YARN-8100
>                 URL: https://issues.apache.org/jira/browse/YARN-8100
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Major
>         Attachments: YARN-8100-YARN-3409.001.patch, 
> YARN-8100-YARN-3409.002.patch
>
>
> Jira is to add api to queue cluster node attributes and Attributes to node 
> query 
> *YarnClient*
> {code}
> getAttributesToNodes()
> getAttributesToNodes(Set<NodeAttribute> attribute)
> getClusterAttributes()
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to