[
https://issues.apache.org/jira/browse/YARN-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426625#comment-16426625
]
Bibin A Chundatt commented on YARN-7875:
----------------------------------------
Thank you [~sunilg]
# Handled checkstyle issue.
# Regarding other testcase failures looks random.YARN-8117 last run all
testcases passed. Locally also did not find any failures
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:3399:
/**: First sentence should end with a period. [JavadocStyle]
{noformat}
Not part of code change
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/FSStoreOpHandler.java:61:
registerLog(NODE_ATTRIBUTE, AddNodeToAttributeLogOp.OPCODE,
AddNodeToAttributeLogOp.class);: Line is longer than 80 characters (found 95).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/FSStoreOpHandler.java:62:
registerLog(NODE_ATTRIBUTE, RemoveNodeToAttributeLogOp.OPCODE,
RemoveNodeToAttributeLogOp.class);: Line is longer than 80 characters (found
101). [LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/FSStoreOpHandler.java:63:
registerLog(NODE_ATTRIBUTE, ReplaceNodeToAttributeLogOp.OPCODE,
ReplaceNodeToAttributeLogOp.class);: Line is longer than 80 characters (found
103). [LineLength]
{noformat}
As discussed offline its better to be in same line
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/op/AddNodeToAttributeLogOp.java:0::
Missing package-info.java file. [JavadocPackage]
{noformat}
Added package-info file
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NodeAttributesManagerImpl.java:73:
protected Dispatcher dispatcher;:24: Variable 'dispatcher' must be private
and have accessor methods. [VisibilityModifier]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NodeAttributesManagerImpl.java:74:
protected NodeAttributeStore store;:32: Variable 'store' must be private and
have accessor methods. [VisibilityModifier]
{noformat}
package-private for testcase purpose.
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestFileSystemNodeAttributeStore.java:22:import
org.apache.hadoop.net.Node;:8: Unused import - org.apache.hadoop.net.Node.
[UnusedImports]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestFileSystemNodeAttributeStore.java:40:public
class TestFileSystemNodeAttributeStore {: Missing a Javadoc comment.
[JavadocType]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestFileSystemNodeAttributeStore.java:42:
MockNodeAttrbuteManager mgr = null;:27: Variable 'mgr' must be private and
have accessor methods. [VisibilityModifier]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestFileSystemNodeAttributeStore.java:43:
Configuration conf = null;:17: Variable 'conf' must be private and have
accessor methods. [VisibilityModifier]
{noformat}
Handled the same.
Thank you
> AttributeStore for store and recover attributes
> -----------------------------------------------
>
> Key: YARN-7875
> URL: https://issues.apache.org/jira/browse/YARN-7875
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-7875-WIP.patch, YARN-7875-YARN-3409.001.patch,
> YARN-7875-YARN-3409.002.patch, YARN-7875-YARN-3409.003.patch,
> YARN-7875-YARN-3409.004.patch, YARN-7875-YARN-3409.005.patch,
> YARN-7875-YARN-3409.006.patch, YARN-7875-YARN-3409.007.patch,
> YARN-7875-YARN-3409.008.patch
>
>
> Similar to NodeLabelStore need to support NodeAttributeStore for persisting
> attributes mapping to Nodes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
