[
https://issues.apache.org/jira/browse/YARN-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427780#comment-16427780
]
Naganarasimha G R commented on YARN-8100:
-----------------------------------------
Thanks for the patch [~bibinchundatt],
Overall the patch looks fine except for these minor issues:
ApplicationClientProtocol,GetAttributesToNodesRequest,GetAttributesToNodesResponse,applicationclient_protocol.proto,yarn_protos.proto,yarn_service_protos.proto,YarnClient.java,ApplicationClientProtocolPBServiceImpl.java
etc... : getAttributeToNodes is used in some places and in some places
getAttributesToNodes, i would prefer to have the former but in any case better
to be uniform across.
YarnClient.java
* ln no 932 - 949 : we can have single method getAttributesToNodes which takes
Set<NodeAttribute> as argument and if its null or empty then we can return for
all the attributes. I understand that its in parlance to labels api, but was
not clear why 2 api's are required with hardly any difference. If not atleast
we can have method names different like getAttributeMapping
* ln no 938 : it should be specified attribute(s) and as well based on
previous comment, please update the documentation.
* ln no 906 : it can be worded as "to get all unique node attributes
configured in the cluster".
GetAttributesToNodesResponse
* ln no 50 : 55: javadoc is not mapping to the api.
GetAttributesToNodesRequestPBImpl
* ln no 131: need to modify nodeLabelsList => nodeAttributesList
GetAttributesToNodesResponsePBImpl
* ln no 60 : need to modify initLabelsToNodes => initAttributesToNodes
* ln no 85 : addLabelsToNodesToProto => addAttributesToNodesToProto
NodeAttributesManagerImpl
* ln no 359 : comment not required
There are many applicable checkstyle issues, hope to see them addressed in the
next patch.
> Support API interface to query cluster attributes and attribute to nodes
> ------------------------------------------------------------------------
>
> Key: YARN-8100
> URL: https://issues.apache.org/jira/browse/YARN-8100
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-8100-YARN-3409.001.patch,
> YARN-8100-YARN-3409.002.patch, YARN-8100-YARN-3409.003.patch,
> YARN-8100-YARN-3409.004.patch
>
>
> Jira is to add api to queue cluster node attributes and Attributes to node
> query
> *YarnClient*
> {code}
> getAttributesToNodes()
> getAttributesToNodes(Set<NodeAttribute> attribute)
> getClusterAttributes()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
