[
https://issues.apache.org/jira/browse/YARN-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428606#comment-16428606
]
Sunil G commented on YARN-7574:
-------------------------------
Hi [~suma.shivaprasad]
Thanks for the patch. Few comments.
1. RMAppAttemptImpl changes seems like we could do in RMAppImpl itself during
Start or Recover call flow. Any advantage in doing it in RMAppAttemptImpl?
2. GuaranteedOrZeroCapacityOverTimePolicy#init code comments are not complete
{{//Should this be used inste}}
3. In same above method {{Set<String> parentQueueLabels =
parentQueue.getNodeLabelsForQueue();}} could be outside for loop.
4. In {{initializeLeafQueueTemplate}}, all calculations are done per label. For
non-exclusive label, given there is a demand from default label, it can borrow
resource from other labels. How could we handle this here? cc/ [~leftnoteasy]
5. You might need to review the checkstyle failures as possible.
6. In TestAppManager, we pass null now. I think its should be empty string rt.
> Add support for Node Labels on Auto Created Leaf Queue Template
> ---------------------------------------------------------------
>
> Key: YARN-7574
> URL: https://issues.apache.org/jira/browse/YARN-7574
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Suma Shivaprasad
> Assignee: Suma Shivaprasad
> Priority: Major
> Attachments: YARN-7574.1.patch, YARN-7574.10.patch,
> YARN-7574.2.patch, YARN-7574.3.patch, YARN-7574.4.patch, YARN-7574.5.patch,
> YARN-7574.6.patch, YARN-7574.7.patch, YARN-7574.8.patch, YARN-7574.9.patch
>
>
> YARN-7473 adds support for auto created leaf queues to inherit node labels
> capacities from parent queues. Howebver there is no support for leaf queue
> template to allow different configured capacities for different node labels.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
