[
https://issues.apache.org/jira/browse/YARN-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430229#comment-16430229
]
Junping Du commented on YARN-7598:
----------------------------------
Thanks [~xgong] for the updating the patch!
The patch looks generally good to me, but have several comments:
bq. so users/admins don't have do anything for it to support NM restart.
"don't have do" => "don't have to do" or "don't need to do"
{noformat}
+ <property>
+
<name>yarn.nodemanager.aux-services.CustomAuxService.classpath</name>
+ <value>${local_dir_to_jar}/*</value>
+ </property>
+
+ <!--
+ <property>
+
<name>yarn.nodemanager.aux-services.CustomAuxService.remote-classpath</name>
+ <value>${remote-dir_to_jar}/CustomAuxService.jar</value>
+ </property>
+ -->
{noformat}
the example above looks a bit misleading, it should point to single jar or
multiple jars no matter local or remote classpath. Isn't it? If so, better to
point to the same jar or jars. Also, what will happen if specify local and
remote classpath at the same time? Better to document here.
Other looks good to me.
> Document how to use classpath isolation for aux-services in YARN
> ----------------------------------------------------------------
>
> Key: YARN-7598
> URL: https://issues.apache.org/jira/browse/YARN-7598
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Priority: Major
> Attachments: YARN-7598.2.patch, YARN-7598.3.patch,
> YARN-7598.trunk.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
