Jason Lowe commented on YARN-7996:

Thanks for the patch!  Looks good to me overall.  I agree with Billie's comment 
about clarifying what's expected in the config field.

Nit: The following code should have a debug log enabled check at the front of 
the conditional
      if (tokens != null && tokens.length != 0) {
        for (Token<?> token : tokens) {
          LOG.debug("Got DT: " + token);

It's a little odd for validateDockerClientConfiguration to go through the 
motions to build a full URI but then limit that URI check to a particular 
filesystem.  Is that intentional, or should it be calling Path#getFileSystem 
instead of assuming it should use fs.getFileSystem()?

> Allow user supplied Docker client configurations with YARN native services
> --------------------------------------------------------------------------
>                 Key: YARN-7996
>                 URL: https://issues.apache.org/jira/browse/YARN-7996
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Shane Kumpf
>            Assignee: Shane Kumpf
>            Priority: Major
>         Attachments: YARN-7996.001.patch, YARN-7996.002.patch, 
> YARN-7996.003.patch, YARN-7996.004.patch
> YARN-5428 added support to distributed shell for supplying a Docker client 
> configuration at application submission time. The auth tokens within the 
> client configuration are then used to pull images from private Docker 
> repositories/registries. Add the same support to the YARN Native Services 
> framework.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to