[
https://issues.apache.org/jira/browse/YARN-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431607#comment-16431607
]
Gour Saha commented on YARN-8126:
---------------------------------
[~rohithsharma] the patch looks good. Few minor comments -
h5. SystemServiceManagerImpl.java
getbadDirSkipCounter make b in bad uppercase
h5. Configurations.md
All service AM specific configs go here. If I understand correctly
{{yarn.service.system-service.dir}} is a cluster-specific config, right?
Also, thanks for deleting TestSystemServiceManager.java which had all upgrade
specific tests. I think I missed this in my first round review :)
> [Follow up] Support auto-spawning of admin configured services during
> bootstrap of rm
> -------------------------------------------------------------------------------------
>
> Key: YARN-8126
> URL: https://issues.apache.org/jira/browse/YARN-8126
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Major
> Attachments: YARN-8126.001.patch
>
>
> YARN-8048 adds support auto-spawning of admin configured services during
> bootstrap of rm.
> This JIRA is to follow up some of the comments discussed in YARN-8048.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
