Naganarasimha G R commented on YARN-8104:

Thanks for the patches [~bibinchundatt], 

_Currently IMHO don't make sense since NodeAttributeManagerImpl doesn't use 
NodeId. We can take up this point once we support in NodeAttributeManager._

I never meant the comment should change the API in NodeAttributeManager neither 
are there any plans in that direction. Till now the apis exposed are either 
internal or admin related. But for user whether it would make sense to have API 
for NodeId is the question here.

 Also was wondering what would be the behavior if ip's are used instead of 
hostnames while mapping?

 _GetNodesToAttributesResponseProto yarn_service.proto requires the same 



hadoop-mapreduce-client-jobclient unit tests either failed or timed out can you 
have a local run and share the results ?


Apart from that patch LGTM !


> Add API to fetch node to attribute mapping
> ------------------------------------------
>                 Key: YARN-8104
>                 URL: https://issues.apache.org/jira/browse/YARN-8104
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Major
>         Attachments: YARN-8104-YARN-3409.001.patch, 
> YARN-8104-YARN-3409.002.patch, YARN-8104-YARN-3409.003.patch, 
> YARN-8104-YARN-3409.004.patch, YARN-8104-YARN-3409.005.patch
> Add node/host to attribute mapping in yarn client API.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to