[ https://issues.apache.org/jira/browse/YARN-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440700#comment-16440700 ]
Abhishek Modi commented on YARN-8137: ------------------------------------- Thanks [~giovanni.fumarola] for reviewing the patch. {quote}You have this instruction {{int threadPoolSize = Math.max(poolSize, 10);}} instead of 10 you should have {{SLSConfiguration.RUNNER_POOL_SIZE_DEFAULT;}} {quote} Will fix it. {quote}{{executorService.awaitTermination(1, TimeUnit.HOURS);}} I think the awaiting time is too long. How did you come up with this value? {quote} I tried with 5000 nodes and it was taking around similar time without this fix. I will reduce it to 10 minutes with this fix. > Parallelize node addition in SLS > -------------------------------- > > Key: YARN-8137 > URL: https://issues.apache.org/jira/browse/YARN-8137 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Abhishek Modi > Assignee: Abhishek Modi > Priority: Major > Attachments: YARN-8137.001.patch > > > Right now, nodes are added sequentially and it can take a long time if there > are large number of nodes. With this change nodes will be added in parallel > and thus reduce the node addition time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org