[ https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442013#comment-16442013 ]
Akira Ajisaka edited comment on YARN-8169 at 4/18/18 7:11 AM: -------------------------------------------------------------- Cancelling my +1. Would you add a period to the end of the javadoc of the constructor to fix the below checkstyle warning? https://builds.apache.org/job/PreCommit-YARN-Build/20370/artifact/out/patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt {noformat} ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/RackResolver.java:46: /**: First sentence should end with a period. [JavadocStyle] {noformat} I'm +1 if that is addressed. was (Author: ajisakaa): Cancelling my +1. Would you add period to the end of the javadoc of the constructor to fix the below checkstyle warning? https://builds.apache.org/job/PreCommit-YARN-Build/20370/artifact/out/patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt {noformat} ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/RackResolver.java:46: /**: First sentence should end with a period. [JavadocStyle] {noformat} I'm +1 if that is addressed. > Review RackResolver.java > ------------------------ > > Key: YARN-8169 > URL: https://issues.apache.org/jira/browse/YARN-8169 > Project: Hadoop YARN > Issue Type: Improvement > Components: yarn > Affects Versions: 3.0.1 > Reporter: BELUGA BEHR > Priority: Trivial > Attachments: YARN-8169.1.patch > > > # Use SLF4J > # Fix some checkstyle warnings > # Minor clean up -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org