[ 
https://issues.apache.org/jira/browse/YARN-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444660#comment-16444660
 ] 

Giovanni Matteo Fumarola commented on YARN-7900:
------------------------------------------------

Thanks, [~botong] for putting this together and for showing me your code on 
some running machines.

 

I took a quick look at it.
Please add Javadoc for the 2 constructors in ResourceRequestSet. Just to 
highlight the difference.
In general, I would add more Javadoc for the public methods around this patch 
for easy understanding. 

> [AMRMProxy] AMRMClientRelayer for stateful FederationInterceptor
> ----------------------------------------------------------------
>
>                 Key: YARN-7900
>                 URL: https://issues.apache.org/jira/browse/YARN-7900
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Major
>         Attachments: YARN-7900.v1.patch, YARN-7900.v2.patch, 
> YARN-7900.v3.patch, YARN-7900.v4.patch, YARN-7900.v5.patch, YARN-7900.v6.patch
>
>
> Inside stateful FederationInterceptor (YARN-7899), we need a component 
> similar to AMRMClient that remembers all pending (outstands) requests we've 
> sent to YarnRM, auto re-register and do full pending resend when YarnRM fails 
> over and throws ApplicationMasterNotRegisteredException back. This JIRA adds 
> this component as AMRMClientRelayer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to