[
https://issues.apache.org/jira/browse/YARN-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446344#comment-16446344
]
Miklos Szegedi commented on YARN-6675:
--------------------------------------
Thank you for the patch [~haibochen].
Can you address this checkstyle and the unit test issue?
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java:1077:
protected String getContainerPid(Path pidFilePath) throws Exception {:41:
'pidFilePath' hides a field. [HiddenField]
Also, your comments and the unit tests describe the scheduling logic nicely but
I would write a user/administrator facing documentation about the logic in
another jira. This one is already too big.
> Add NM support to launch opportunistic containers based on overallocation
> -------------------------------------------------------------------------
>
> Key: YARN-6675
> URL: https://issues.apache.org/jira/browse/YARN-6675
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha3
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Priority: Major
> Attachments: YARN-6675-YARN-1011.00.patch,
> YARN-6675-YARN-1011.prelim0.patch, YARN-6675-YARN-1011.prelim1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
