[ 
https://issues.apache.org/jira/browse/YARN-8168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455631#comment-16455631
 ] 

Íñigo Goiri edited comment on YARN-8168 at 4/27/18 1:26 AM:
------------------------------------------------------------

The approach in [^YARN-8168.000.patch] looks good.

I would add some comment describing the approach being taken here and what 
would be the case when there is only one.
>From the code, we switch to each CPU gorup and we collect those stats.
What does Linux do?

I would also try to create a couple functions if possible; for example one to 
get the core info.


was (Author: elgoiri):
 [^YARN-8168.000.patch] looks good.

I would add some comment describing the approach being taken here and what 
would be the case when there is only one.
>From the code, we switch to each CPU gorup and we collect those stats.
What does Linux do?

> Add support in Winutils for reporting CPU cores in all CPU groups, and 
> aggregate kernel time, idle time and user time for all CPU groups
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8168
>                 URL: https://issues.apache.org/jira/browse/YARN-8168
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Xiao Liang
>            Assignee: Xiao Liang
>            Priority: Major
>              Labels: windows
>         Attachments: YARN-8168.000.patch
>
>
> Currently winutils can only report the CPU cores of the CPU group that it's 
> running in, and the cpuTimeMs calculated from kernel time, idle time and user 
> time is also for that CPU group only, which is not complete and incorrect for 
> systems with multiple CPU groups (NUMA system for example).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to