[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460255#comment-16460255 ]
Eric Yang commented on YARN-8207: --------------------------------- [~Jim_Brennan] Thank you for the review. I made the changes according to your comments in patch 004. For the last part, fixed array is safer than dynamic one. The original patch in YARN-7654 was mostly static allocation. I think it is safer to use static size for args to prevent any chance of stack overflow by dynamic allocation of large string array. Make_string was suggested by Jason to improve code readability. > Docker container launch use popen have risk of shell expansion > -------------------------------------------------------------- > > Key: YARN-8207 > URL: https://issues.apache.org/jira/browse/YARN-8207 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-native-services > Reporter: Eric Yang > Assignee: Eric Yang > Priority: Major > Attachments: YARN-8207.001.patch, YARN-8207.002.patch, > YARN-8207.003.patch, YARN-8207.004.patch > > > Container-executor code utilize a string buffer to construct docker run > command, and pass the string buffer to popen for execution. Popen spawn a > shell to run the command. Some arguments for docker run are still vulnerable > to shell expansion. The possible solution is to convert from char * buffer > to string array for execv to avoid shell expansion. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org