[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461567#comment-16461567 ]
Shane Kumpf edited comment on YARN-8206 at 5/2/18 8:03 PM: ----------------------------------------------------------- Thanks [~ebadger]! {quote}I'm looking through the code and I thought that error message had always been a problem. {quote} You're right, the warning isn't something introduced by this patch. I'm fine with addressing that in a separate JIRA. was (Author: shaneku...@gmail.com): Thanks [~ebadger]! {quote}I'm looking through the code and I thought that error message had always been a problem.\{quote} You're right, the warning isn't something introduced by this patch. I'm fine with addressing that in a separate JIRA. > Sending a kill does not immediately kill docker containers > ---------------------------------------------------------- > > Key: YARN-8206 > URL: https://issues.apache.org/jira/browse/YARN-8206 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Eric Badger > Assignee: Eric Badger > Priority: Major > Attachments: YARN-8206.001.patch, YARN-8206.002.patch, > YARN-8206.003.patch > > > {noformat} > if (ContainerExecutor.Signal.KILL.equals(signal) > || ContainerExecutor.Signal.TERM.equals(signal)) { > handleContainerStop(containerId, env); > {noformat} > Currently in the code, we are handling both SIGKILL and SIGTERM as equivalent > for docker containers. However, they should actually be separate. When YARN > sends a SIGKILL to a process, it means for it to die immediately and not sit > around waiting for anything. This ensures an immediate reclamation of > resources. Additionally, if a SIGTERM is sent before the SIGKILL, the task > might not handle the signal correctly, and will then end up as a failed task > instead of a killed task. This is especially bad for preemption. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org