[ 
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763315#comment-13763315
 ] 

Zhijie Shen commented on YARN-978:
----------------------------------

The patch looks good, but it's better to add some javadoc for 
YarnApplicationAttemptState and ApplicationAttemptReport, because it's 
user-oriented.

Another question is whether all RMAppAttemptState states are meaningful to 
users to have the 1-to-1 mapping. I've noticed that YarnApplicationState 
combined FINISHING and FINISHED. Thoughts?

If we decided not to expose host, rpc port, and tracking url via rpc protocol, 
we should be consistent via web (YARN-954 and YARN-1023).

                
> [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
> ----------------------------------------------------------------------
>
>                 Key: YARN-978
>                 URL: https://issues.apache.org/jira/browse/YARN-978
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Xuan Gong
>             Fix For: YARN-321
>
>         Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, 
> YARN-978.4.patch, YARN-978.5.patch, YARN-978.6.patch
>
>
> We dont have ApplicationAttemptReport and Protobuf implementation.
> Adding that.
> Thanks,
> Mayank

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to