[ 
https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466274#comment-16466274
 ] 

Miklos Szegedi commented on YARN-7715:
--------------------------------------

Thank you for the review [~haibochen].

I added a unit test for TestContainerSchedulerQueuing.

I am hesitant to update or not update cgroups based on some hash maps updated 
by asynchronous code. That might become a supportability nightmare. I already 
added a proper check of running containers by checking whether the cgroup 
directory exists.

> Update CPU and Memory cgroups params on container update as well.
> -----------------------------------------------------------------
>
>                 Key: YARN-7715
>                 URL: https://issues.apache.org/jira/browse/YARN-7715
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Miklos Szegedi
>            Priority: Major
>         Attachments: YARN-7715.000.patch, YARN-7715.001.patch, 
> YARN-7715.002.patch
>
>
> In YARN-6673 and YARN-6674, the cgroups resource handlers update the cgroups 
> params for the containers, based on opportunistic or guaranteed, in the 
> *preStart* method.
> Now that YARN-5085 is in, Container executionType (as well as the cpu, memory 
> and any other resources) can be updated after the container has started. This 
> means we need the ability to change cgroups params after container start.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to