[
https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469522#comment-16469522
]
genericqa commented on YARN-8270:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 8s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
34s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 47s{color} | {color:orange}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 33 new
+ 32 unchanged - 0 fixed = 65 total (was 32) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 14s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
39s{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
59s{color} | {color:green} hadoop-yarn-server-timelineservice in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 68m
41s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs |
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
|
| | Nullcheck of entities at line 345 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String,
String) At TimelineReaderWebServices.java:345 of value previously dereferenced
in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String,
String) At TimelineReaderWebServices.java:[line 345] |
| | Nullcheck of entities at line 629 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String,
String, String, String, String, String) At TimelineReaderWebServices.java:629
of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String,
String, String, String, String, String) At
TimelineReaderWebServices.java:[line 629] |
| | Nullcheck of entities at line 1946 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRunApps(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String)
At TimelineReaderWebServices.java:1946 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRunApps(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String)
At TimelineReaderWebServices.java:[line 1946] |
| | Nullcheck of entities at line 1219 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRuns(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String)
At TimelineReaderWebServices.java:1219 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRuns(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String)
At TimelineReaderWebServices.java:[line 1219] |
| | Nullcheck of entities at line 1378 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRuns(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String) At TimelineReaderWebServices.java:1378 of value previously
dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRuns(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String) At TimelineReaderWebServices.java:[line 1378] |
| | Nullcheck of entities at line 1522 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlows(HttpServletRequest,
HttpServletResponse, String, String, String, String) At
TimelineReaderWebServices.java:1522 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlows(HttpServletRequest,
HttpServletResponse, String, String, String, String) At
TimelineReaderWebServices.java:[line 1522] |
| | Nullcheck of entities at line 3522 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getSubAppEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String) At TimelineReaderWebServices.java:3522 of
value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getSubAppEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String) At TimelineReaderWebServices.java:[line 3522] |
| | Nullcheck of entities at line 3446 of value previously dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getSubAppEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String,
String, String) At TimelineReaderWebServices.java:3446 of value previously
dereferenced in
org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getSubAppEntities(HttpServletRequest,
HttpServletResponse, String, String, String, String, String, String, String,
String, String, String, String, String, String, String, String, String, String,
String, String) At TimelineReaderWebServices.java:[line 3446] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8270 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12922671/YARN-8270.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 50a9778d9879 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12
21:23:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / af4fc2e |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/20667/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/20667/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/20667/testReport/ |
| Max. process+thread count | 821 (vs. ulimit of 10000) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/20667/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Adding JMX Metrics for Timeline Collector and Reader
> ----------------------------------------------------
>
> Key: YARN-8270
> URL: https://issues.apache.org/jira/browse/YARN-8270
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: ATSv2, timelineserver
> Reporter: Sushil Kumar S
> Priority: Major
> Attachments: YARN-8270.001.patch
>
>
> This Jira is for emitting JMX Metrics for ATS v2 Timeline Collector and
> Timeline Reader, basically for Timeline Collector it tries to capture
> success, failure and latencies for *putEntities* and *putEntitiesAsync* from
> *TimelineCollectorWebService* and all the API's success, failure and
> latencies for fetching TimelineEntities from *TimelineReaderWebServices*.
> This would actually help in monitoring and measuring performance for ATSv2 at
> scale.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
