[ https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472258#comment-16472258 ]
Szilard Nemeth commented on YARN-8248: -------------------------------------- Thanks [~haibochen] for your comments! # I added some code in one of the earlier version of this patch to Resources. Then when I removed that code since it turned out it's unnecessary, I realized the IDE showed that the continue statements are not required, so it's a simple code cleanup. If it is discouraged in general to touch anything other than the bare minimum needed to fix the issue, I will remove those changes. But I'm still curious what's the correct way of working if I detect something minor code fix like that later on. Creating a separate Jira task for that seems overkill. # Those debug logs still are not strictly necessary, but these logs helped me to understand why the FS hangs, so in the end I kept those logs because I think it could save a lot of time for anyone if such an edge case happens what I fixed. If you don't agree with this, I can remove the logs. # Good catch, I will fix this. Please check 1 and 2 and decide how to go forward with those, the 3rd is rather trivial to fix.\ Thanks! > Job hangs when queue is specified and that queue has 0 capability of a > resource > ------------------------------------------------------------------------------- > > Key: YARN-8248 > URL: https://issues.apache.org/jira/browse/YARN-8248 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler, yarn > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-8248-001.patch, YARN-8248-002.patch, > YARN-8248-003.patch, YARN-8248-004.patch, YARN-8248-005.patch > > > Job hangs when mapreduce.job.queuename is specified and the queue has 0 of > any resource (vcores / memory / other) > In this scenario, the job should be immediately rejected upon submission > since the specified queue cannot serve the resource needs of the submitted > job. > > Command to run: > {code:java} > bin/yarn jar > "./share/hadoop/mapreduce/hadoop-mapreduce-examples-$MY_HADOOP_VERSION.jar" > pi -Dmapreduce.job.queuename=sample_queue 1 1000;{code} > fair-scheduler.xml queue config (excerpt): > > {code:java} > <queue name="sample_queue"> > <minResources>10000 mb,0vcores</minResources> > <maxResources>90000 mb,0vcores</maxResources> > <maxRunningApps>50</maxRunningApps> > <maxAMShare>-1.0f</maxAMShare> > <weight>2.0</weight> > <schedulingPolicy>fair</schedulingPolicy> > </queue> > {code} > Diagnostic message from the web UI: > {code:java} > Wed May 02 06:35:57 -0700 2018] Application is added to the scheduler and is > not yet activated. (Resource request: <memory:1536, vCores:1> exceeds current > queue or its parents maximum resource allowed).{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org