[ https://issues.apache.org/jira/browse/YARN-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472621#comment-16472621 ]
Shane Kumpf edited comment on YARN-8141 at 5/11/18 8:41 PM: ------------------------------------------------------------ {quote}I agree that at this time, it's better to not remove YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS {quote} Fair enough. the original environment variable does make the intent explicit for relative source paths. However, YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS won't work for '/etc/passwd' as originally described in this issue, this is what YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS is for. Can you help me understand the use case in allowing the user to provide YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS? I'm struggling to come up with a good use case for this. was (Author: shaneku...@gmail.com): {quote}I agree that at this time, it's better to not remove YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS {quote} Fair enough. the original environment variable does make the user intent explicit for relative source paths. However, YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS won't work for '/etc/passwd' as originally described in this issue, this is what YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS is for. Can you help me understand the use case in allowing the user to provide YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS? I'm struggling to come up with a good use case for this. > YARN Native Service: Respect > YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS specified in service spec > ---------------------------------------------------------------------------------------------------------- > > Key: YARN-8141 > URL: https://issues.apache.org/jira/browse/YARN-8141 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn-native-services > Reporter: Wangda Tan > Assignee: Chandni Singh > Priority: Critical > Attachments: YARN-8141.001.patch, YARN-8141.002.patch, > YARN-8141.003.patch > > > Existing YARN native service overwrites > YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS regardless if user > specified this in service spec or not. It is important to allow user to mount > local folders like /etc/passwd, etc. > Following logic overwrites the > YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS environment: > {code:java} > StringBuilder sb = new StringBuilder(); > for (Entry<String,String> mount : mountPaths.entrySet()) { > if (sb.length() > 0) { > sb.append(","); > } > sb.append(mount.getKey()); > sb.append(":"); > sb.append(mount.getValue()); > } > env.put("YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS", > sb.toString());{code} > Inside AbstractLauncher.java -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org