[
https://issues.apache.org/jira/browse/YARN-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476942#comment-16476942
]
Szilard Nemeth commented on YARN-4599:
--------------------------------------
Thanks [[email protected]] for the updated patch!
LGTM, I just noticed some small things:
1. {{CGroupElasticMemoryController}} constructor: oomHandlerTemp is
unnecessary, please directly assign {{getDefaultOOMHandler}}'s return value to
field oomHandler.
2. {{CGroupElasticMemoryController}} constructor: In the first and second
{{LOG.warn()}} I guess you wanted to use {{NM_ELASTIC_MEMORY_CONTROL_ENABLED}}
instead of NM_ELASTIC_MEMORY_CONTROL_OOM_TIMEOUT_SEC.
3. {{DefaultOOMHandler.killContainerIfOOM}}: Sorry my comment was wrong, it's
clear for me that it converts MB to bytes correctly.
Maybe it's worth to consider using
{{org.apache.hadoop.yarn.util.UnitsConversionUtil#convert}} as this is the main
converter method used to convert values like this.
4. {{DefaultOOMHandler}} constructor: typo in javadoc, "hander"
> Set OOM control for memory cgroups
> ----------------------------------
>
> Key: YARN-4599
> URL: https://issues.apache.org/jira/browse/YARN-4599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Miklos Szegedi
> Priority: Major
> Labels: oct16-medium
> Attachments: Elastic Memory Control in YARN.pdf, YARN-4599.000.patch,
> YARN-4599.001.patch, YARN-4599.002.patch, YARN-4599.003.patch,
> YARN-4599.004.patch, YARN-4599.005.patch, YARN-4599.006.patch,
> YARN-4599.007.patch, YARN-4599.008.patch, YARN-4599.009.patch,
> YARN-4599.sandflee.patch, yarn-4599-not-so-useful.patch
>
>
> YARN-1856 adds memory cgroups enforcing support. We should also explicitly
> set OOM control so that containers are not killed as soon as they go over
> their usage. Today, one could set the swappiness to control this, but
> clusters with swap turned off exist.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
