[
https://issues.apache.org/jira/browse/YARN-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483140#comment-16483140
]
Jason Lowe commented on YARN-8329:
----------------------------------
Thanks for the patch!
I'm wondering why the code is filtering the tokens by kind into a separate
credentials only to pass that to another method which will also filter the
tokens by the same kind. Can't we just iterate the original credentials
directly, ignoring tokens that aren't the appropriate kind? I'm not seeing why
the copy is necessary. Eliminating the copy would also eliminate the need to
do a token identifier decode to construct an alias.
> Docker client configuration can still be set incorrectly
> --------------------------------------------------------
>
> Key: YARN-8329
> URL: https://issues.apache.org/jira/browse/YARN-8329
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.2.0, 3.1.1
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Priority: Major
> Labels: Docker
> Attachments: YARN-8329.001.patch
>
>
> YARN-7996 implemented a fix to avoid writing an empty Docker client
> configuration file, but there are still cases where the {{docker --config}}
> argument is set in error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
