[
https://issues.apache.org/jira/browse/YARN-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488092#comment-16488092
]
Jason Lowe commented on YARN-8292:
----------------------------------
Thanks for updating the patch! The TestPreemptionForQueueWithPriorities
failure appears to be related.
Nit: Using the new isAnyMajorResourceAboveZero method will be a bit more
readable and more efficient than the fitsIn check against none since fitsIn
does unnecessary unit conversion checks.
What is the point of the new static methods added to Resources? It's more
succinct to call the ResourceCalculator method directly, e.g.:
rc.isAnyMajorResourceZeroOrNegative(resource) instead of
Resources.isAnyMajorResourceZeroOrNegative(rc, resource).
It would be good to cleanup the whitespace nit. Speaking of whitespace, one of
the checkstyle errors was caused by a whitespace-only formatting change in this
patch (the for loop in computeFixpointAllocation)
> Fix the dominant resource preemption cannot happen when some of the resource
> vector becomes negative
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-8292
> URL: https://issues.apache.org/jira/browse/YARN-8292
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Sumana Sathish
> Assignee: Wangda Tan
> Priority: Critical
> Attachments: YARN-8292.001.patch, YARN-8292.002.patch,
> YARN-8292.003.patch, YARN-8292.004.patch, YARN-8292.005.patch,
> YARN-8292.006.patch, YARN-8292.007.patch
>
>
> This is an example of the problem:
>
> {code}
> // guaranteed, max, used, pending
> "root(=[30:18:6 30:18:6 12:12:6 1:1:1]);" + //root
> "-a(=[10:6:2 10:6:2 6:6:3 0:0:0]);" + // a
> "-b(=[10:6:2 10:6:2 6:6:3 0:0:0]);" + // b
> "-c(=[10:6:2 10:6:2 0:0:0 1:1:1])"; // c
> {code}
> There're 3 resource types. Total resource of the cluster is 30:18:6
> For both of a/b, there're 3 containers running, each of container is 2:2:1.
> Queue c uses 0 resource, and have 1:1:1 pending resource.
> Under existing logic, preemption cannot happen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
