[
https://issues.apache.org/jira/browse/YARN-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491275#comment-16491275
]
Botong Huang commented on YARN-8175:
------------------------------------
Overall the patch looks good to me. Two minor comments:
1. SLSUtils.java and TestSLSUtils.java, include SLSRunner.NodeDetails at top so
that we only need to use NodeDetails in the code.
2. SLSUtils.buildNodeLabelsFromStr() I am wondering if there's any parsing
library code we can use here? Also please add some javadoc/comments for the
method explaining the expected input string format, an example would be nice.
> Add support for Node Labels in SLS.
> -----------------------------------
>
> Key: YARN-8175
> URL: https://issues.apache.org/jira/browse/YARN-8175
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-8175.001.patch, YARN-8175.002.patch,
> YARN-8175.003.patch, YARN-8175.004.patch, YARN-8175.005.patch
>
>
> Currently, SLS doesn't support node labels. With this jira, we are planning
> to add support for node labels in SLS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
