[ 
https://issues.apache.org/jira/browse/YARN-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504910#comment-16504910
 ] 

Íñigo Goiri commented on YARN-8175:
-----------------------------------

Isn't there anywhere else where we have something like 
{{buildNodeLabelsFromStr()}}?
It looks like this would be something already done in the CLI.
I think somebody more familiar with node labels should take a look to double 
check we are not doing the same things twice.

The coverage in the unit test looks better.
I would still use the map of nodes and check one by one directly and not with 
the for loop though.

> Add support for Node Labels in SLS
> ----------------------------------
>
>                 Key: YARN-8175
>                 URL: https://issues.apache.org/jira/browse/YARN-8175
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Abhishek Modi
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-8175.001.patch, YARN-8175.002.patch, 
> YARN-8175.003.patch, YARN-8175.004.patch, YARN-8175.005.patch, 
> YARN-8175.006.patch, YARN-8175.007.patch
>
>
> Currently, SLS doesn't support node labels. With this jira, we are planning 
> to add support for node labels in SLS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to