[ 
https://issues.apache.org/jira/browse/YARN-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth updated YARN-8325:
---------------------------------
    Attachment: YARN-8325.002.patch

> Miscellaneous QueueManager code clean up
> ----------------------------------------
>
>                 Key: YARN-8325
>                 URL: https://issues.apache.org/jira/browse/YARN-8325
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Haibo Chen
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: YARN-8325.001.patch, YARN-8325.002.patch
>
>
> getLeafQueue(String name, boolean create, boolean recomputeSteadyShares) and
> getLeafQueue(String name,  boolean create,  boolean recomputeSteadyShares),  
> setChildResourceLimits() can be declared as private.
>  ensureRootPrefix() should be static.
> The static LOG field should be private.
> The log in
>       if (!parent.getPolicy().isChildPolicyAllowed(childPolicy)) {
>         LOG.error("Can't create queue '" + queueName + "'.");
>         return null;
>       }
> can be improved by the specific reason, ie. the child scheduling policy is 
> not allowed by that of its parent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to