[ https://issues.apache.org/jira/browse/YARN-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509952#comment-16509952 ]
Hudson commented on YARN-8325: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14410 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14410/]) YARN-8325. Miscellaneous QueueManager code clean up. (Szilard Nemeth via (haibochen: rev 10d0e4be6eade7c1685b9c6962bc9b18e33122a8) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java > Miscellaneous QueueManager code clean up > ---------------------------------------- > > Key: YARN-8325 > URL: https://issues.apache.org/jira/browse/YARN-8325 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Reporter: Haibo Chen > Assignee: Szilard Nemeth > Priority: Minor > Fix For: 3.2.0 > > Attachments: YARN-8325.001.patch, YARN-8325.002.patch > > > getLeafQueue(String name, boolean create, boolean recomputeSteadyShares) and > getLeafQueue(String name, boolean create, boolean recomputeSteadyShares), > setChildResourceLimits() can be declared as private. > ensureRootPrefix() should be static. > The static LOG field should be private. > The log in > if (!parent.getPolicy().isChildPolicyAllowed(childPolicy)) { > LOG.error("Can't create queue '" + queueName + "'."); > return null; > } > can be improved by the specific reason, ie. the child scheduling policy is > not allowed by that of its parent. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org