[
https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511938#comment-16511938
]
Haibo Chen commented on YARN-8270:
----------------------------------
Thanks [~Sushil-K-S] for updating the patch! The unit test failures are
unrelated. A few comments on the new patch.
1) I think we should do ' boolean isAsync = async != null &&
async.trim().equalsIgnoreCase("true");' before the try-catch clause. Otherwise,
if there is an exception thrown before isAsync is processed, the failure would
be reported as as sync putEntities() failure even though the asyn parameter is
set to true.
2) TimelineCollectorMetrics should probably be renamed to
PerNodeAggregateTimelineCollectorMetrics as we have discussed in the call.
3) Both TImelineServiceV2Publisher and TimelineCollectorWebService run with the
same Node Manager JVM, because we run PerNodeTimelineCollectorsAuxService as an
auxiliary service. This would lead to double counting of the sync putEntities
Metrics, right? I think we can either use a different metric for
TimelineServiceV2Publisher if we want to capture metrics that is not captured
by TimelineCollectorWebService, or just remove the metrics from
TimelineServiceV2Publisher.
4) "GET timeline entities success count" (and the other similar ones) sounds a
bit ambiguous to me. In TimelineCollectorMetrics, that's the total number of
entities of all the putEntities() requests that are processed successfully. in
TimelineReaderMetrics, it's the total number of entities that are returned to
getEntity() requests. The current descriptions are almost the same, but their
meanings are very different. Can we be more specific in the description?
5) TimelineReaderMetrics.getEntitiesFailureCount is always zero. What do you
think of removing it since it is always zero?
The asflicense and checkstyle issues are related.
> Adding JMX Metrics for Timeline Collector and Reader
> ----------------------------------------------------
>
> Key: YARN-8270
> URL: https://issues.apache.org/jira/browse/YARN-8270
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2, timelineserver
> Reporter: Sushil Ks
> Assignee: Sushil Ks
> Priority: Major
> Attachments: YARN-8270.001.patch
>
>
> This Jira is for emitting JMX Metrics for ATS v2 Timeline Collector and
> Timeline Reader, basically for Timeline Collector it tries to capture
> success, failure and latencies for *putEntities* and *putEntitiesAsync* from
> *TimelineCollectorWebService* and all the API's success, failure and
> latencies for fetching TimelineEntities from *TimelineReaderWebServices*.
> This would actually help in monitoring and measuring performance for ATSv2 at
> scale.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
