[
https://issues.apache.org/jira/browse/YARN-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514061#comment-16514061
]
Íñigo Goiri edited comment on YARN-8412 at 6/15/18 4:35 PM:
------------------------------------------------------------
Thanks [~botong] for the patch.
I've removed the duplicated patches.
Regarding the patch itself, I think it makes sense to consolidate all the clone
methods into a single one.
The only one I'm not sure about is TestAppManager#cloneResourceRequest.
This one seems to be doing a copy of the label expression and the capability
instead of just a link.
Do you mind double checking this one?
Can you also make sure that TestAMRestart works fine in your machine?
was (Author: elgoiri):
Thanks [~botong] for the patch.
I've removed the duplicated patches.
Regarding the patch itself, I think it makes sense to consolidate all the clone
methods into a single one.
The only one I'm not sure about is TestAppManager#cloneResourceRequest.
This one seems to be doing a copy of the label expression and the capability
instead of just a link.
Do you mind double checking this one?
> Move ResourceRequest.clone logic everywhere into a proper API
> -------------------------------------------------------------
>
> Key: YARN-8412
> URL: https://issues.apache.org/jira/browse/YARN-8412
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Minor
> Attachments: YARN-8412.v1.patch, YARN-8412.v2.patch
>
>
> ResourceRequest.clone code is replicated in lots of places, some missing to
> copy one field or two due to new fields added over time. This JIRA attempts
> to move them into a proper API so that everyone can use this single
> implementation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
